GoogleCloudPlatform / GoogleCloudPlatform/opentelemetry-operations-java

instrumentation-quickstart example log4j2 config always sends `logging.googleapis.com/trace_sampled: true`

Open
#331 0 comments 0 reactions 0 assignees View on GitHub
documentation priority: p3
Dominant language
Java
Stars
78
Forks
39
Avg merge
14m
Merged PRs (30d)
1

Description

We send `true` even if trace was not sampled. See https://github.com/apache/logging-log4j2/discussions/2482 for context. In the meantime, sending `true` keeps the "View trace details" button working. Added in https://github.com/GoogleCloudPlatform/opentelemetry-operations-java/pull/330

Contributor guide

Open the contributing guide

Assessment

This issue has not been assessed yet.

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.