GoogleCloudPlatform / GoogleCloudPlatform/netd

Always collect metrics for the root ns and optionally collect metrics for the pod namespaces

Open
#115 0 comments 0 reactions 0 assignees View on GitHub
Dominant language
Go
Stars
77
Forks
48
PR merge metrics
No merged PRs in 30d

Description

Basically the way we collect netlink metrics makes it necessary to turn on `hostPID`, which we are not ready to do yet.

See https://github.com/GoogleCloudPlatform/netd/pull/113#discussion_r692547470 for the context - adding an issue so that we don't lose track.
```
I think we can do two things - always collect metrics for the root ns (and label it by the node IP I guess) and optionally if the pod watch is enabled, also collect metrics for the pod namespaces.

I think this will require some additional work to figure out how to export the root ns metrics into a K8sContainer schema. So for now, I think just create an issue so we don't lose track and we can merge this PR.
```

cc @varunmar @michaelasp

Contributor guide

Open the contributing guide

Assessment

This issue has not been assessed yet.

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.