GoogleCloudPlatform / GoogleCloudPlatform/market-data-transcoder

Add separate options for `--input_prefix_length` and `--output_prefix_length`

Open
#139 0 comments 0 reactions 0 assignees View on GitHub
boundary condition enhancement
Dominant language
Python
Stars
47
Forks
11
Avg merge
19d 10h
Merged PRs (30d)
2

Description

`LengthDelimitedOutputManager` takes the `--prefix_length` command line option to size the int representing the prefix length for a message sent to the output stream. However, `LengthDelimitedInputSource` also uses the `--prefix_length` option for reading input streams that are length-prefixed.

The two options are distinct and should be separately instrumented. The clash namely occurs in a relatively rare situation, for example you are reframing messages and either narrowing or widening the prefix length as part of the process.

Contributor guide

Open the contributing guide

Assessment

This issue has not been assessed yet.

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.