GoogleCloudPlatform / GoogleCloudPlatform/kubernetes-engine-samples

Remove Terraform duplication in `streaming/`

Open
#861 1 comment 0 reactions 0 assignees View on GitHub
priority: p3 type: cleanup
Dominant language
HCL
Stars
1.4k
Forks
1.3k
Avg merge
2d 2h
Merged PRs (30d)
4

Description

* See [this comment](https://github.com/GoogleCloudPlatform/kubernetes-engine-samples/pull/725#discussion_r1316150606).
* The Terraform inside `/streaming/kafka-strimzi/terraform` is mostly identical to the Terraform added by https://github.com/GoogleCloudPlatform/kubernetes-engine-samples/pull/725.
* We should minimize this duplication.
* This would involve:
* [ ] creating more generic (re-usable) Terraform (e.g., inside `/streaming/kafka/terraform`)
* [ ] updating the two tutorials (Strimzi and Confluent) to use the new generic Terraform (`/streaming/kafka/terraform`)
* [ ] removing unused Strimzi-specific and Confluent-sepecific Terraform from this repo

Contributor guide

Open the contributing guide

Assessment

This issue has not been assessed yet.

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.