GoogleCloudPlatform / GoogleCloudPlatform/kubernetes-engine-samples
Provide testing for pubsub code sample
Open
priority: p3
type: process
- Dominant language
- HCL
- Stars
- 1.4k
- Forks
- 1.3k
- Avg merge
- 2d 2h
- Merged PRs (30d)
- 4
Description
Currently the code sample in `cloud-pubsub/` does not have testing. After upgrading the code to use pubsub client library version 2.*, we can leverage existing [tests] to support testing of the code sample.
_Originally posted by @anguillanneuf in https://github.com/GoogleCloudPlatform/kubernetes-engine-samples/pull/608#pullrequestreview-1429625428_
[tests]: https://github.com/googleapis/python-pubsub/blob/15d6cdf5ca2eeb6b2fcccc92fc1c69fef2ad07c9/samples/snippets/subscriber_test.py#L638
Contributor guide
Assessment
This issue has not been assessed yet.