GoogleCloudPlatform / GoogleCloudPlatform/kubernetes-engine-samples

Remove need to manually write workflow definition for `docker build` test

Open
#1,587 0 comments 0 reactions 0 assignees View on GitHub
Dominant language
HCL
Stars
1.4k
Forks
1.3k
Avg merge
2d 2h
Merged PRs (30d)
4

Description

* Currently, pull-request workflows in https://github.com/GoogleCloudPlatform/kubernetes-engine-samples/tree/main/.github/workflows that test `docker build`ing of Dockerfiles are written manually for each new Dockerfile added into this repo.
* Instead, we may be able to write some code _once_ and have all Dockerfiles (even those added in the future) tested in pull-requests.
* This removes to need for comments like this: https://github.com/GoogleCloudPlatform/kubernetes-engine-samples/pull/1585#discussion_r1909317913

Contributor guide

Open the contributing guide

Assessment

This issue has not been assessed yet.

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.