GoogleCloudPlatform / GoogleCloudPlatform/k8s-stackdriver
custom-metrics-stackdriver-adapter should use DefaultTokenSource
Open
custom-metrics-stackdriver-adapter
- Dominant language
- Go
- Stars
- 409
- Forks
- 236
- Avg merge
- 2h 34m
- Merged PRs (30d)
- 9
Description
Although Stackdriver Monitoring is not support only GCP but also multi-cloud and hybrid-cloud deployment,
`custom-metrics-stackdriver-adapter` is strongly tied with GCE/GKE because it use `ComputeTokenSource`.
`DefaultTokenSource` should be more widely useful option because it allows to use `GOOGLE_APPLICATION_CREDENTIALS`.
I am not testing it yet but it will be a small patch like below.
https://github.com/apstndb/k8s-stackdriver/commit/5cc3399c0225ea527e7b9bed6ab27b47b435a45b
Contributor guide
Assessment
This issue has not been assessed yet.