GoogleCloudPlatform / GoogleCloudPlatform/k8s-stackdriver
Default Value Type for prometheus-to-sd
Open
- Dominant language
- Go
- Stars
- 409
- Forks
- 236
- Avg merge
- 2h 34m
- Merged PRs (30d)
- 9
Description
The current default type is ["INT64"](https://github.com/GoogleCloudPlatform/k8s-stackdriver/blob/master/prometheus-to-sd/translator/translator.go#L282)
This is breaking floating point metrics such as: "custom.googleapis.com/kube-state-metrics/kube_pod_container_resource_requests_cpu_cores"
Since the variable that holds the Value is of type float64 already, I think the best candidate for default type should be "DOUBLE" instead of "INT64".
Contributor guide
Assessment
This issue has not been assessed yet.