GoogleCloudPlatform / GoogleCloudPlatform/k8s-stackdriver

[prometheus-to-sd] containerNameLabel being checked in ValidateMetricDescriptors (in metric_descriptor_cache.go)

Open
#299 0 comments 0 reactions 0 assignees View on GitHub
Dominant language
Go
Stars
409
Forks
236
Avg merge
2h 34m
Merged PRs (30d)
9

Description

According to the README, prometheus labels are not included as labels in stackdriver ("Note that prometheus labels used for the monitored resource are not included as labels in stackdriver.").

The behaviour in ValidateMetricDescriptors (in metric_descriptor_cache.go) seems to clash with this, as it does check the containerNameLabel label and warns us with the message `Definition of the metric %s was changed and metric is not going to be pushed`

Contributor guide

Open the contributing guide

Assessment

This issue has not been assessed yet.

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.