GoogleCloudPlatform / GoogleCloudPlatform/gsutil
Latest version of pyopenssl breaks gsutil signurl
- Dominant language
- Python
- Stars
- 918
- Forks
- 335
- PR merge metrics
- No merged PRs in 30d
Description
Hey there, this https://github.com/pyca/pyopenssl/pull/1223/files change in `pyopenssl` removed `load_pkcs12` from `OpenSSL.crypto`. signurl used it directly https://github.com/GoogleCloudPlatform/gsutil/blob/master/gslib/commands/signurl.py#L57 and with it now missing it triggers a misleading error message that `pyopenssl` is not installed.
Also listed in the changelog https://github.com/pyca/pyopenssl/blob/c8b8c1eed352fc48cfe9e7052094857249525176/CHANGELOG.rst#backward-incompatible-changes (although there's a typo and they say they removed `OpenSSL.crypto.loads_pkcs12`).
Sorry I can't contribute a fix
Contributor guide
Research direction
Start in gslib/commands/signurl.py around line 57 and inspect how the missing OpenSSL.crypto.load_pkcs12 import is handled. Reproduce signurl with the latest pyOpenSSL, then verify that the resulting behavior no longer reports pyOpenSSL as simply uninstalled; add or update the relevant coverage if the repository provides it.
Written by the indexing model from the issue text.
Assessment
- Tech stack
- python
- Domain
- cli
- Issue type
- Bug
- Difficulty
- 2/5
- Estimated time
- 1-3 hours
- Activity status
- Stale
- Clarity
- Clearly specified
- Newbie friendliness
- 48/100