GoogleCloudPlatform / GoogleCloudPlatform/grpc-gcp-java

gRPC-client-user-guide suggests using master

Open
#4 0 comments 0 reactions 1 assignee Claimed by @ZhouyihaiDing View on GitHub
Dominant language
Java
Stars
11
Forks
23
PR merge metrics
No merged PRs in 30d

Description

gRPC-client-user-guide.md suggests cloning current master from both protobuf and grpc:
```
$ git clone https://github.com/google/protobuf.git
$ cd $HOME/protobuf
$ ./autogen.sh && ./configure && make -j8
```

```
$ git clone https://github.com/grpc/grpc-java.git
$ cd grpc-java/compiler
$ ../gradlew java_pluginExecutable
```

If doing testing, that can be fine, but it will be trivially broken when gRPC or proto is enhancing its generated code. You should generate at a tagged version that matches the runtime version (of the deps in pom.xml), or older.

For example, if the version of gRPC in the Maven file is 1.9.0, then you may only use generated code from tagged releases from 1.9.0 and earlier.

Contributor guide

No contributing guide indexed for this repository

Assessment

This issue has not been assessed yet.

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.