GoogleCloudPlatform / GoogleCloudPlatform/google-cloud-eclipse

Implement modify listener mechanism to GoogleLoginService / make AccountSelector a viewer

Open
#842 0 comments 0 reactions 0 assignees View on GitHub
cleanup priority: p4
Dominant language
Java
Stars
90
Forks
52
PR merge metrics
No merged PRs in 30d

Description

This way, multiple viewers (such as `AccountSelector`) of the login state can be synchronized whenever the login state changes.

Note that, however, at the current state, nothing would be broken even if we had multiple `AccountSelector`s some of which are stale; the selector is currently self-sufficient, carrying actual credentials with it. In that sense, the selector is not just a viewer. This issue also suggests to convert the selector to a mere viewer.

Contributor guide

Open the contributing guide

Assessment

This issue has not been assessed yet.

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.