GoogleCloudPlatform / GoogleCloudPlatform/google-cloud-eclipse

Get rid of ANALYTICS_OPT_IN_REGISTERED preference setting

Open
#319 1 comment 0 reactions 0 assignees View on GitHub
cleanup priority: p4 ready
Dominant language
Java
Stars
90
Forks
52
PR merge metrics
No merged PRs in 30d

Description

From the discussion in #309.

For the purpose of determining whether a user has seen the metrics opt-in dialog or not, the current implementation is to save this state in a preference setting by the name of ANALYTICS_OPT_IN_REGISTERED. This creates a potentially confusing relation with the setting ANALYTICS_OPT_IN, which indicates if a user has opted in or not. It has also been pointed out in #309 that the has-seen state is not a "preference".

We can get rid of the OPT_IN_REGISTERED setting if we employ a three-valued preference setting with ANALYTICS_OPT_IN: OPTED_IN, OPTED_OUT, UNDEF. This is conceptually ideal, resulting in only one clean setting.

Contributor guide

Open the contributing guide

Assessment

This issue has not been assessed yet.

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.