GoogleCloudPlatform / GoogleCloudPlatform/gcsfuse
Update linter for all Go code
- Dominant language
- Go
- Stars
- 2.3k
- Forks
- 510
- Avg merge
- 2d 17h
- Merged PRs (30d)
- 35
Description
While testing code changes @shubham-diwakar and I came across that the linter used for gcsfuse does not inspect existing files that are already committed and only changes in a PR.
Example:
```
Error: Error return value of `util.Unmount` is not checked (errcheck)
Error: Error return value of `util.Unmount` is not checked (errcheck)
Error: Error return value of `util.Unmount` is not checked (errcheck)
Error: Error return value of `cmd.Wait` is not checked (errcheck)
Error: Error return value of `cmd.Process.Kill` is not checked (errcheck)
```
Linter workflow needs to be updated to also lint existing code as well. This came up with in forked repo setup and filing an issue here since this is the source of truth.
Contributor guide
Research direction
Start by locating the repository's linter workflow and checking why it only inspects changed files in pull requests. Run the workflow against the existing Go code, including the reported unchecked returns, and confirm that committed files are linted as well.
Written by the indexing model from the issue text.
Assessment
- Tech stack
- go
- Domain
- ci-cd, tooling
- Issue type
- Bug
- Difficulty
- 3/5
- Estimated time
- 1-2 days
- Activity status
- Stale
- Clarity
- Mostly clear
- Newbie friendliness
- 35/100