GoogleCloudPlatform / GoogleCloudPlatform/functions-framework-php

Integration tests aren't compatible with rennovatebot

Open
#162 1 comment 0 reactions 0 assignees View on GitHub
bug P2
Dominant language
PHP
Stars
213
Forks
37
PR merge metrics
No merged PRs in 30d

Description

Rennovatebot isn't creating branches on the local repository, so the conformance tests which require this are failing. It's likely they will also fail for other external PRs as well.

https://github.com/GoogleCloudPlatform/functions-framework-php/blob/5b645eedc7508a16481c364e8cd209fb176d3e03/tests/conformance/prerun.sh#L25

We should instead direct the integration tests to point at the currently checked out source in the GitHub action's pipeline. Perhaps something like this: https://stackoverflow.com/questions/29994088/composer-require-local-package

Contributor guide

Open the contributing guide

Assessment

This issue has not been assessed yet.

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.