GoogleCloudPlatform / GoogleCloudPlatform/esp-v2

Support precious quota enforcement with added latency

Open
#499 3 comments 1 reaction 0 assignees View on GitHub
enhancement
Dominant language
Go
Stars
307
Forks
185
Avg merge
14h 45m
Merged PRs (30d)
6

Description

The [quotas](https://cloud.google.com/endpoints/docs/openapi/quotas-configure) limit is per minute, so if we get status code `429 Too Many Request` and we wait a minute we should be fine but after we wait a minute the next request has status code `429`, it happens even if we wait more than twice like `150` seconds. I can reproduce the issue with a simple example in [this repo](https://github.com/jyeros/esp-quota-limit). In the github action logs, there is one waiting `61` seconds with the issue and other waiting `150` with the same issue.

Contributor guide

Open the contributing guide

Research direction

Reproduce the quota behavior using the linked esp-quota-limit repository and inspect the GitHub Action runs showing waits of 61 and 150 seconds. Compare the proxy's handling with the Cloud Endpoints quota documentation; done means requests no longer receive 429 after the documented quota window has elapsed.

Written by the indexing model from the issue text.

Assessment

Tech stack
go, google-cloud
Domain
api, backend
Issue type
Bug
Difficulty
4/5
Estimated time
3-5 days
Activity status
Stale
Clarity
Needs clarification
Newbie friendliness
35/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.