GoogleCloudPlatform / GoogleCloudPlatform/datashare-toolkit
Add destination datasetID creation in README
- Dominant language
- JavaScript
- Stars
- 94
- Forks
- 27
- PR merge metrics
- No merged PRs in 30d
Description
**Describe the bug**
add destination datasetID creation in README. Spot Fulfillment API requires a destination datasetID to execute BQ jobs. This is missing from the README. The default points to [bqds_spot_fulfillment](
https://github.com/GoogleCloudPlatform/bq-datashare-toolkit/blob/master/api/v1alpha/src/validateManager.js#L35)
**To Reproduce**
Steps to reproduce the behavior:
1. Go to [api](../tree/master/api)
2. Run through install and launch
3. Try to POST /fulfullmentRequests with *wait: true*
4. See error
**Expected behavior**
no errors
**Additional context**
Will need to add a configuration option [here](../tree/master/api#create-storage-bucket) and anywhere there should be a reference to *FULFILLMENT_CONFIG_DESTINATION_DATASET_ID*
Contributor guide
Assessment
This issue has not been assessed yet.