GoogleCloudPlatform / GoogleCloudPlatform/database-migration-wave-orchestrator

ER: Use Secrets to store source db password for Postgres

Open
#36 0 comments 0 reactions 1 assignee Claimed by @Giulianos View on GitHub
enhancement
Dominant language
Python
Stars
13
Forks
8
PR merge metrics
No merged PRs in 30d

Description

### Enhancement Request Details

The DB password for Postgres is being stored as plaintext. This should be stored as a secret.

Changes required:

- Table `configs` should have a `password_secret_id` field instead of the plaintext password
- ConfigEditor for DMS should accept a **Password Secret ID** parameter instead of the plaintext password
- When running the deploy, the password should be retrieved from Secrets API using the `password_secret_id` stored in the config.

### Version

None

### What database engine is this documentation change for?

None

### Relevant log output

_No response_

Contributor guide

Open the contributing guide

Assessment

This issue has not been assessed yet.

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.