GoogleCloudPlatform / GoogleCloudPlatform/compute-image-tools

Image Build Workflows: Add support for custom network/subnetwork as well as customer service account

Open
#2,329 1 comment 0 reactions 0 assignees View on GitHub
enhancement
Dominant language
Go
Stars
220
Forks
168
Avg merge
1d 8h
Merged PRs (30d)
6

Description

Add support for custom network/subnetwork as well as custom service account.

Image import had added this capability previously so there is prior art at https://github.com/GoogleCloudPlatform/compute-image-import/blob/110224ec011a4a84856ea6081115a9ed61c35da9/daisy_workflows/image_import/inflate_file.wf.json#L92.

- Ensure default still work as expected
- Update all the build and publish workflows
- Test to ensure all of the default work correctly on the updated workflow
- Update documentation on how to specify custom network and subnetwork / service account

Previous customer challenges around these capabilities:
- https://github.com/GoogleCloudPlatform/compute-image-tools/issues/2233

Contributor guide

Open the contributing guide

Research direction

Start by reviewing the prior art in daisy_workflows/image_import/inflate_file.wf.json around line 92, then locate all build and publish workflows in this repository. Verify that defaults still work, add coverage for custom network, subnetwork, and service account settings, and update the documentation describing those options.

Written by the indexing model from the issue text.

Assessment

Tech stack
google-cloud
Domain
cloud, infrastructure
Issue type
Feature
Difficulty
4/5
Estimated time
3-5 days
Activity status
Stale
Clarity
Mostly clear
Newbie friendliness
35/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.