GoogleCloudPlatform / GoogleCloudPlatform/cloud-sql-proxy

Telemetry doesn't work with non-ADC

Open
#2,204 1 comment 0 reactions 1 assignee Claimed by @hessjcg View on GitHub
priority: p3 type: bug
Dominant language
Go
Stars
1.4k
Forks
352
Avg merge
14h 54m
Merged PRs (30d)
5

Description

If I launch the Proxy with an OAuth2 token or a credentials file while using Telemetry, the Proxy fails to start.

The reason for this is stackdriver does requires that we set non-ADC in the stackdriver.Options struct:

https://github.com/GoogleCloudPlatform/cloud-sql-proxy/blob/3f9e2de1633843f010ad2227dfdc92dda189208f/cmd/root.go#L972-L975

In addition, the Proxy should love the error as we've disabled error reporting after parsing the config.

Contributor guide

Open the contributing guide

Assessment

This issue has not been assessed yet.

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.