GoogleCloudPlatform / GoogleCloudPlatform/cloud-sql-go-connector

Improve tests that use `mock/certs.go`

Open
#950 0 comments 0 reactions 1 assignee Assigned to @hessjcg View on GitHub
priority: p2 type: cleanup
Dominant language
Go
Stars
145
Forks
35
Avg merge
3d 22h
Merged PRs (30d)
5

Description

We should improve tests that use `internal/mock/certs.go`

Instead of panic'ing which we currently do it would be better if we were to pass the `*testing.T` parameter through and fail the test.

https://github.com/GoogleCloudPlatform/cloud-sql-go-connector/blob/cc63f695ddc8f245ba8ba9bf5562e2cce00e9640/internal/mock/certs.go#L126-L134

Contributor guide

Open the contributing guide

Assessment

This issue has not been assessed yet.

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.