GoogleCloudPlatform / GoogleCloudPlatform/cloud-spanner-r2dbc

Re-enable TCK tests

Open
#488 0 comments 0 reactions 1 assignee Claimed by @elefeint View on GitHub
enhancement P2 release-blockers
Dominant language
Java
Stars
60
Forks
31
PR merge metrics
No merged PRs in 30d

Description

I had to disable the whole TCK class temporarily because there are 7 tests failing due to not-yet-implemented functionality.

Remove [this line](https://github.com/GoogleCloudPlatform/cloud-spanner-r2dbc/blob/5b4487e6368d0e0510e2126e8eb8c15661366fea/cloud-spanner-r2dbc/src/test/java/com/google/cloud/spanner/r2dbc/it/SpannerClientLibraryTestKit.java#L61) to re-enable.

- [ ] columnMetadata()
- [ ] prepareStatementWithTrailingAddShouldFail
- [ ] segmentInsertWithFilterCompletesWithoutOnNext
- [ ] row
- [ ] segmentInsertEmitsUpdateCount
- [ ] segmentSelectWithEmitsRow
- [ ] segmentSelectWithFilterCompletesWithoutOnNext

Several of the above have to do with implementing the [Segment API](https://github.com/r2dbc/r2dbc-spi/pull/215).
The [R2DBC SPI changelog](https://r2dbc.io/spec/1.0.0.RELEASE/CHANGELOG.txt) describes all differences from 0.8 SPI to 1.0 SPI, with PR numbers describing each in detail.

Contributor guide

Open the contributing guide

Assessment

This issue has not been assessed yet.

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.