GoogleCloudPlatform / GoogleCloudPlatform/cloud-run-button

Prompt just before deploying the application (for security)?

Open
#35 0 comments 0 reactions 0 assignees View on GitHub
enhancement
Dominant language
Go
Stars
553
Forks
98
PR merge metrics
No merged PRs in 30d

Description

This is primarily because Cloud Run default service account currently has broad capabilities (Editor) on user’s GCP project.

So if someone clicks to the button to deploy a malicious repository, they might just go with it which would’ve ended up stealing their tokens.

Right now we show this indicator:

[ ✓ ] Cloned git repository https://github.com/foo/bar.
[ ✓ ] Queried list of your GCP projects
[ ✓ ] Found 3044 projects in your GCP account.

and then definitely prompt for input at least once once for a GCP project.

Does this give user enough chance to **review** the git repo being deployed –or should we show the user another confirmation like:

[ ? ] Do you allow application at https://github.com/foo/bar to be deployed? (Y/n)

I'm not sure.

Contributor guide

Open the contributing guide

Assessment

This issue has not been assessed yet.

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.