GoogleCloudPlatform / GoogleCloudPlatform/cloud-run-button

Project selector suggests invalid projects

Open
#177 0 comments 1 reaction 0 assignees View on GitHub
bug good first issue
Dominant language
Go
Stars
553
Forks
98
PR merge metrics
No merged PRs in 30d

Description

Introduced in #149, the API for the project list includes all lifecycle types, including projects pending deletion.

The list of projects should only be those with lifecycle == "ACTIVE" (this is the default in gcloud, effectively `--filter='lifecycleState:ACTIVE'`.)

https://cloud.google.com/resource-manager/reference/rest/v1/projects/list
https://cloud.google.com/resource-manager/reference/rest/v1/projects#LifecycleState

Reproduction:

```
[ ? ] Choose a project to deploy this application: butt [Use arrows to move, type to filter]
❯ glasnt-cloudrun-button-0364 ^C
~$ gcloud projects list --format "value(project_id, lifecycle_state)" --filter='lifecycleState:*'
glasnt-cloudrun-button-0364 DELETE_REQUESTED
```

Contributor guide

Open the contributing guide

Assessment

This issue has not been assessed yet.

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.