GoogleCloudPlatform / GoogleCloudPlatform/cloud-run-button

Both Cloud Run Button and Heroku Button - app.json Clash

Open
#112 28 comments 0 reactions 0 assignees View on GitHub
Dominant language
Go
Stars
553
Forks
98
PR merge metrics
No merged PRs in 30d

Description

I am trying to add the Cloud Run Button to [one of our repositories](https://github.com/jhipster/jhipster-registry) which has the [Heroku Deploy Button](https://devcenter.heroku.com/articles/heroku-button) which also uses an [`app.json` file](https://devcenter.heroku.com/articles/heroku-button).

This creates problems when trying to add the Cloud Run button to the same repository as the Cloud Run also assumes an `app.json` file and the Heroku `app.json` file which is different in format will crash the Cloud Run when trying to deploy. Also I am unable to define an `app.json` file for Cloud Run since one already exists for Heroku.

Is there a possibility to configure the name of the `app.json` file (or just name it differently) for example so that it doesn't clash with other cloud providers such as Heroku? :smile:

Contributor guide

Open the contributing guide

Assessment

This issue has not been assessed yet.

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.