GoogleCloudPlatform / GoogleCloudPlatform/cloud-opensource-java

LinkageCheckRequest and LinkageCheckRequest.Builder

Open
#1,329 0 comments 0 reactions 1 assignee Claimed by @suztomo View on GitHub
p3 Tech Debt
Dominant language
Java
Stars
163
Forks
80
PR merge metrics
No merged PRs in 30d

Description

Current design of creating LinkageChecker for every class path looks strange. Let's change the parameters into `LinkageCheckRequest` class.

```
LinkageChecker linkageChecker = LinkageChecker.create();
LinkageCheckRequest.Builder request = LinkageCheckRequest.builder()
.classPath(classPath)
.exclusionFile(exclusionFile);

// current findSymbolProblems()
ImmutableSetMultimap = linkageChecker.check(request.build());
```

The `linkageChecker` instance does not hold any information. Maybe a static method should suffice:

```
LinkageCheckRequest.Builder request = LinkageCheckRequest.builder()
.classPath(classPath)
.exclusionFile(exclusionFile);
ImmutableSetMultimap result = LinkageChecker.check(request.build());
```

Contributor guide

Open the contributing guide

Assessment

This issue has not been assessed yet.

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.