GoogleCloudPlatform / GoogleCloudPlatform/cloud-opensource-java

Linkage Checker incorrectly picks up provided dependency rather than compile dependency

Open
#1,185 1 comment 0 reactions 1 assignee Claimed by @suztomo View on GitHub
bug p3
Dominant language
Java
Stars
163
Forks
80
PR merge metrics
No merged PRs in 30d

Description

Linkage Checker reported an error that will never manifest in users environment.

```
(gson-2.2.4.jar) com.google.gson.stream.JsonReader's method getPath() is not found;
referenced by 1 class file
io.grpc.internal.JsonParser (grpc-core-1.25.0.jar)
```

In veblush's Linkage Check result https://gist.github.com/veblush/a9470a977ed8dfa2f3e94f4c9f3957c7#file-gistfile1-txt-L83, it shows that Linkage Checker picks up gson:2.2.4 (old) in provided dependency. However, Maven (or Gradle) will never pick up the old version for users' environments, because it's provided dependency.

gson:2.2.4 (provided) was picked up
```
org.apache.beam:beam-runners-google-cloud-dataflow-java:2.20.0-SNAPSHOT (compile)
/ org.apache.beam:beam-sdks-java-extensions-google-cloud-platform-core:2.20.0-SNAPSHOT (compile)
/ com.google.cloud.bigdataoss:gcsio:2.0.0 (compile)
/ com.google.code.gson:gson:2.2.4 (provided)
```

gson:2.8.5 (compile) was not picked up.
```
org.apache.beam:beam-runners-google-cloud-dataflow-java:2.20.0-SNAPSHOT (compile)
/ org.apache.beam:beam-sdks-java-io-google-cloud-platform:2.20.0-SNAPSHOT (compile)
/ io.grpc:grpc-core:1.25.0 (compile)
/ com.google.code.gson:gson:2.8.5 (compile)
```

Contributor guide

Open the contributing guide

Assessment

This issue has not been assessed yet.

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.