GoogleCloudPlatform / GoogleCloudPlatform/cloud-builders-community

entrypoint.bash is non-compliant with Shell Style Guide

Open
#611 0 comments 0 reactions 0 assignees View on GitHub
Dominant language
Go
Stars
1.3k
Forks
848
PR merge metrics
No merged PRs in 30d

Description

I was reviewing https://github.com/google/osv.dev/pull/1017 which has a straight copy of `entrypoint.bash` from this repo, and it's not particularly compliant (or internally consistent) with https://google.github.io/styleguide/shellguide.html (see some of my comments on that PR).

You might like to do something about that.

Contributor guide

Open the contributing guide

Research direction

Locate the repository's entrypoint.bash and compare it with the linked Shell Style Guide and the referenced pull request 1017 comments. Done means the script is internally consistent and conforms to the relevant style guidance, with any behavior preserved.

Written by the indexing model from the issue text.

Assessment

Tech stack
bash
Domain
devops
Issue type
Refactor
Difficulty
2/5
Estimated time
1-3 hours
Activity status
Stale
Clarity
Needs clarification
Newbie friendliness
35/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.