GoogleCloudPlatform / GoogleCloudPlatform/PerfKitBenchmarker

Add a way for users to specify global flag values in the YAML file

Open
#814 0 comments 0 reactions 0 assignees View on GitHub
enhancement
Dominant language
Python
Stars
2k
Forks
562
Avg merge
4h 55m
Merged PRs (30d)
69

Description

I was discussing the YAML config files with @ehankland.

Currently, there's a way to specify flag value overrides per benchmark run. It could be useful to have a way to specify a higher-level flag value override that applies to the entire PKB run.

I assume the priority would be such that the benchmark-specific overrides would take precedence over the global overrides, but because the global flag overrides would still modify the flag values, they would still take precedence over benchmark-specific config options.

Example:

```
flags:
machine_type: n1-standard-1 # Middle priority

iperf:
flags:
machine_type: n1-standard-2 # Highest priority
vm_groups:
default:
GCP:
machine_type: n1-standard-4 # Lowest priority
```

Contributor guide

Open the contributing guide

Assessment

This issue has not been assessed yet.

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.