GoogleCloudPlatform / GoogleCloudPlatform/PerfKitBenchmarker

Improve error messages for Azure disk / storage account type interaction

Open
#754 1 comment 0 reactions 1 assignee Claimed by @noahl View on GitHub
enhancement
Dominant language
Python
Stars
2k
Forks
562
Avg merge
4h 55m
Merged PRs (30d)
69

Description

There's a [failed assert](https://github.com/GoogleCloudPlatform/PerfKitBenchmarker/blob/69d253b355b5f3581100e20381123d8e6ed21059/perfkitbenchmarker/providers/azure/azure_disk.py#L108-L111) when using Azure premium (SSD) disks without a premium storage account. Asserts should be used to confirm invariants, not check user input. Could we make that a bit more friendly?

Contributor guide

Open the contributing guide

Assessment

This issue has not been assessed yet.

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.