GoogleCloudPlatform / GoogleCloudPlatform/PerfKitBenchmarker
Clean up flag formatting in PKB
Open
good first issue
- Dominant language
- Python
- Stars
- 2k
- Forks
- 562
- Avg merge
- 4h 55m
- Merged PRs (30d)
- 69
Description
flags should take the form:
_FOOBAR = flags.DEFINE_...
https://github.com/GoogleCloudPlatform/PerfKitBenchmarker/blob/master/perfkitbenchmarker/linux_benchmarks/sysbench_benchmark.py#L135
Reference the flag later with:
x = FOOBAR.value
https://github.com/GoogleCloudPlatform/PerfKitBenchmarker/blob/master/perfkitbenchmarker/linux_benchmarks/sysbench_benchmark.py#L810
Contributor guide
Assessment
This issue has not been assessed yet.