GoogleCloudPlatform / GoogleCloudPlatform/PerfKitBenchmarker

Add GCP persistent disk ID to metadata of pkb

Open
#5,237 0 comments 0 reactions 0 assignees View on GitHub
good first issue
Dominant language
Python
Stars
2k
Forks
562
Avg merge
4h 55m
Merged PRs (30d)
69

Description

For this task, we want to store the disk ID in the disk metadata.

TASK:

Add a method in CreatePDDiskStrategy https://github.com/GoogleCloudPlatform/PerfKitBenchmarker/blob/master/perfkitbenchmarker/providers/gcp/gce_disk_strategies.py#L56C7-L56C27 called UpdateDiskIDs

In UpdateDiskIDs, iterate through self.remote_disk_groups, then iterate through each disk in the disk group using nested for loop.

for each disk, call self.Describe to get the description json, parse the disk id from the json and add it as a field to disk. i.e. disk.id = 12345

For this task, we will need to provision a disk as well. We can use fio benchmark:

command: ./pkb.py --benchmarks=fio --data_disk_size=10 --data_disk_type=pd-ssd

Contributor guide

Open the contributing guide

Assessment

This issue has not been assessed yet.

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.