GoogleCloudPlatform / GoogleCloudPlatform/PerfKitBenchmarker

Kubernetes provider not supporting pre-provisioned data

Open
#1,938 0 comments 0 reactions 0 assignees View on GitHub
Dominant language
Python
Stars
2k
Forks
562
Avg merge
4h 55m
Merged PRs (30d)
69

Description

Hello there,
when using the flag --benchmark_compatibility_checking=none and a custom VM config (which I may attach if it'd be useful), it is possible to run - for example the redis_enterprise - some workloads, which will in the next stage fail with pre-provisioning error.

`Exception occurred while calling _InstallRedisEnterprise():
Traceback (most recent call last):
File "/home/feelas/perfkit/perfkitbenchmarker/background_tasks.py", line 255, in Run
self.return_value = self.target(*self.args, **self.kwargs)
File "/home/feelas/perfkit/perfkitbenchmarker/linux_benchmarks/redis_enterprise_benchmark.py", line 61, in _InstallRedisEnterprise
vm.Install('redis_enterprise')
File "/home/feelas/perfkit/perfkitbenchmarker/linux_virtual_machine.py", line 1297, in Install
package.AptInstall(self) File "/home/feelas/perfkit/perfkitbenchmarker/linux_packages/redis_enterprise.py", line 111, in AptInstall _Install(vm) File "/home/feelas/perfkit/perfkitbenchmarker/linux_packages/redis_enterprise.py", line 86, in _Install
_WORKING_DIR)
File "/home/feelas/perfkit/perfkitbenchmarker/virtual_machine.py", line 528, in InstallPreprovisionedPackageData
install_path)
File "/home/feelas/perfkit/perfkitbenchmarker/virtual_machine.py", line 426, in _InstallData
self.DownloadPreprovisionedData(install_path, module_name, filename)
File "/home/feelas/perfkit/perfkitbenchmarker/providers/kubernetes/kubernetes_virtual_machine.py", line 484, in DownloadPreprovisionedData
'data on Kubernetes VMs.'.format(cloud))
NotImplementedError: Cloud None does not support downloading preprovisioned data on Kubernetes VMs.`

It would be great if that gets supported, eventually.

Contributor guide

Open the contributing guide

Assessment

This issue has not been assessed yet.

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.