GoogleCloudPlatform / GoogleCloudPlatform/PerfKitBenchmarker

Handle cleanup failure separate from failure

Open
#1,058 0 comments 0 reactions 0 assignees View on GitHub
enhancement P1
Dominant language
Python
Stars
2k
Forks
562
Avg merge
4h 55m
Merged PRs (30d)
69

Description

Currently, a failure on cleanup reports the benchmark as FAILED, even though it produces results. This can be confusing, so I would propose adding another state that is CLEANUP_FAILED, for when the benchmark succeeded and results were produced, but cleanup failed.

This might need to be done carefully, since if just the Cleanup stage is being run, it might be more appropriate to report FAILED the CLEANUP_FAILED.

Contributor guide

Open the contributing guide

Assessment

This issue has not been assessed yet.

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.