GoogleCloudPlatform / GoogleCloudPlatform/Open_Data_QnA
Redundant inference in BuildSQLAgent?
Open
- Dominant language
- Dart
- Stars
- 233
- Forks
- 74
- PR merge metrics
- No merged PRs in 30d
Description
I was going over the inferences that the code performs and my understanding is that there's no point in performing the `send_message` call below if there was no previous question/SQL.
I can suggest a simple PR to avoid if these values are None.
What do you think?
https://github.com/GoogleCloudPlatform/Open_Data_QnA/blob/3075ebc7615544299b237009f9b5c88a9c177537/agents/BuildSQLAgent.py#L128
Contributor guide
Assessment
This issue has not been assessed yet.