GoogleChromeLabs / GoogleChromeLabs/ui-element-samples

Sometimes when closing the menu the overlay disappears without the menu closing

Open
#13 2 comments 0 reactions 0 assignees View on GitHub
Dominant language
JavaScript
Stars
4.1k
Forks
723
Avg merge
3m
Merged PRs (30d)
4

Description

Sometimes when closing the menu the overlay disappears without the menu closing, and then on the following click it appears without the menu. Unsure how to recreate it, it just seems to happen after a few clicks. I assume theres a point where both classes are active or missing.

I've fixed this as well as a few linting issues and remove the need for two functions to display the menu.
Ive attached the gif of the issue, apologies for the quality.
![bug](https://cloud.githubusercontent.com/assets/5321135/14952305/2a4d8798-1057-11e6-89a3-956c35d8a5d7.gif)

Contributor guide

Open the contributing guide

Assessment

This issue has not been assessed yet.

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.