GoogleChromeLabs / GoogleChromeLabs/quicklink

An additional `div` markup is wrapped around each router component by `withQuicklink` HOC

Open
#193 1 comment 1 reaction 0 assignees View on GitHub
help wanted
Dominant language
JavaScript
Stars
11.3k
Forks
429
PR merge metrics
No merged PRs in 30d

Description

**Describe the bug**
As you can see in the HOC, we have an additional `div` markup wrapping around the `Component` (probably it would be a route component) so inserting that `div` markup could break the app styling since the app styling does not expect another `div` to be inserted by withQuicklink HOC.
![Capture](https://user-images.githubusercontent.com/49653735/86411922-8fc7bd80-bcc6-11ea-803d-ef703967e1c5.PNG)

**To Reproduce**
If we use nest CSS selector without considering that `div`, we might break the styling.

**Expected behavior**
I hope we could avoid adding any wrapping markup around a route component if possible. At least, I hope we manage to avoid impacting the rest of the app as well as the styling in any case.

**Version:**
- Quicklink 2.0

cc @addyosmani @demianrenzulli

Contributor guide

Open the contributing guide

Assessment

This issue has not been assessed yet.

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.