GoogleChromeLabs / GoogleChromeLabs/pywebsocket3

Support sending "array" types for binary data

Open
#10 1 comment 0 reactions 0 assignees View on GitHub
enhancement good first issue
Dominant language
Python
Stars
45
Forks
33
PR merge metrics
No merged PRs in 30d

Description

Migrated from https://github.com/google/pywebsocket/issues/131:
```
What steps will reproduce the problem?
1. Construct an array using array.array()
2. Attempt to send it using request.ws_stream.send_message(message, binary=True)

Expected result:

Binary data is sent.

Actual result:

TypeError: web_socket_transfer_data raised exception for /flow-control-test:
cannot concatenate 'str' and 'array.array' objects

Probably a TypeError would be appropriate if binary=False, but when binary=True
this seems a natural way to send large binary objects.
```
Original issue reported on code.google.com by ri...@google.com on 10 Jul 2014 at 10:18

Contributor guide

Open the contributing guide

Assessment

This issue has not been assessed yet.

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.