GoogleChromeLabs / GoogleChromeLabs/progressive-tooling

Paint issues for the header

Open
#30 0 comments 0 reactions 0 assignees View on GitHub
Dominant language
JavaScript
Stars
542
Forks
26
PR merge metrics
No merged PRs in 30d

Description

First, thanks for putting together such an excellent resource ✨.

I created this issue because I saw the header jumping while scrolling as shown below...

![issue](https://user-images.githubusercontent.com/6707780/46055831-681bec80-c113-11e8-9c11-1915d136e578.gif)
------
This element triggers repaints on scroll **only on non-retina displays**, so please consider moving it to its layer.

I came across [this Stack Overflow question](https://stackoverflow.com/a/32744881) that links to [this bug](https://bugs.chromium.org/p/chromium/issues/detail?id=514303) explaining this behavior in devices with different pixels ratio.

![header-fix](https://user-images.githubusercontent.com/6707780/46056107-ab2a8f80-c114-11e8-91fc-8394b55d0ed1.gif)

As a side improvement, the [`ScrollContainerDiv`](https://github.com/GoogleChromeLabs/progressive-tooling/blob/master/src/components/card-scroll/card-scroll.style.js#L21) component should also be moved to its layer to avoid scrolling performance issues.

![screen shot 2018-09-25 at 10 19 43 pm](https://user-images.githubusercontent.com/6707780/46057038-3b6ad380-c119-11e8-8e26-a9cffbdb81be.png)

Contributor guide

Open the contributing guide

Assessment

This issue has not been assessed yet.

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.