GoogleChromeLabs / GoogleChromeLabs/jsvu
Incorrect path being made in .cmd wrapper on windows.
Open
enhancement
good first issue
- Dominant language
- JavaScript
- Stars
- 2k
- Forks
- 98
- PR merge metrics
- No merged PRs in 30d
Description
Following the execution path:
https://github.com/GoogleChromeLabs/jsvu/blob/853836d94d207f6c8f487f272121b0bd4a5f7b72/shared/installer.js#L46
https://github.com/GoogleChromeLabs/jsvu/blob/853836d94d207f6c8f487f272121b0bd4a5f7b72/shared/installer.js#L131-L132
https://github.com/GoogleChromeLabs/jsvu/blob/853836d94d207f6c8f487f272121b0bd4a5f7b72/shared/installer.js#L134
Which results in this:
```
@echo off
"%~dp0engines/v8\v8.exe" --natives_blob="%~dp0engines/v8\natives_blob.bin" --snapshot_blob="%~dp0engines/v8\snapshot_blob.bin" %*
```
Contributor guide
Assessment
This issue has not been assessed yet.