GoogleChromeLabs / GoogleChromeLabs/jsvu

(linux64) JavaScriptCore does not extract archive to ~/.jsvu/bin

Open
#172 3 comments 0 reactions 0 assignees View on GitHub
Dominant language
JavaScript
Stars
2k
Forks
98
PR merge metrics
No merged PRs in 30d

Description

Looking at `extract.js` `installer.installScript({...})` is not executed and the download that winds up in `/tmp` ("jsvutmpf") is not extracted to `~/.jsvu`

```
case 'linux64': {
const installer = new Installer({
engine: binary,
path: tmpPath,
});
installer.installLibraryGlob('lib/*');
installer.installBinary({ 'bin/jsc': binary }, { symlink: false });
installer.installScript({
name: binary,
alias: alias,
generateScript: (targetPath) => {
console.log({ targetPath }); // Never printed
return `
#!/usr/bin/env bash
LD_LIBRARY_PATH="${targetPath}/lib" exec "${targetPath}/lib/ld-linux${
os === 'linux64' ? '-x86-64' : '' }.so.2" "${targetPath}/${binary}" "$@"
`;
}
});
break;
}
```

Contributor guide

Open the contributing guide

Assessment

This issue has not been assessed yet.

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.