GoogleChromeLabs / GoogleChromeLabs/bubblewrap

Difficult to fully automate this (CI/CD)

Open
#806 3 comments 2 reactions 0 assignees View on GitHub
Dominant language
TypeScript
Stars
3.1k
Forks
319
PR merge metrics
No merged PRs in 30d

Description

**Describe the bug**
Unable to make this truly non-interactive and supported in a GitHub Action

**To Reproduce**
(GitHub Action - Ubuntu 22.04)
1. `npx bubblewrap updateConfig --jdkPath="$JAVA_HOME_11_X64" --androidSdkPath="/usr/local/lib/android/sdk";`
2. `npx bubblewrap doctor && npx bubblewrap build`

**Expected behavior**
I wish for it to work.

**Screenshots**
```
,-----. ,--. ,--. ,--.
| |) /_,--.,--| |-.| |-.| |,---.,--. ,--,--.--.,--,--.,---.
| .-. | || | .-. | .-. | | .-. | |.'.| | .--' ,-. | .-. |
| '--' ' '' | `-' | `-' | \ --| .'. | | \ '-' | '-' '
`------' `----' `---' `---'`--'`----'--' '--`--' `--`--| |-'
`--'
? Do you want Bubblewrap to install JDK?
(Enter "No" to use your JDK installation) (Y/n)
Error: Process completed with exit code 130.
```

**Desktop (please complete the following information):**
- OS: Ubuntu 22.04

**Additional context**
I thought I was using this wrong, so I peeked at the official action and tried out the container with:

```
docker run --rm -ti ghcr.io/googlechromelabs/bubblewrap:latest build --config config.json
,-----. ,--. ,--. ,--.
| |) /_,--.,--| |-.| |-.| |,---.,--. ,--,--.--.,--,--.,---.
| .-. | || | .-. | .-. | | .-. | |.'.| | .--' ,-. | .-. |
| '--' ' '' | `-' | `-' | \ --| .'. | | \ '-' | '-' '
`------' `----' `---' `---'`--'`----'--' '--`--' `--`--| |-'
`--'
? Do you want Bubblewrap to install JDK?
(Enter "No" to use your JDK installation) (Y/n)
```

However, it validates fine with doctor so I am confused why its asking for the SDK information like it doesn't exist in both my action and the official container.
```
,-----. ,--. ,--. ,--.
| |) /_,--.,--| |-.| |-.| |,---.,--. ,--,--.--.,--,--.,---.
| .-. | || | .-. | .-. | | .-. | |.'.| | .--' ,-. | .-. |
| '--' ' '' | `-' | `-' | \ --| .'. | | \ '-' | '-' '
`------' `----' `---' `---'`--'`----'--' '--`--' `--`--| |-'
`--'
doctor Your jdkpath and androidSdkPath are valid.
```

Contributor guide

Open the contributing guide

Assessment

This issue has not been assessed yet.

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.