GoogleChromeLabs / GoogleChromeLabs/bubblewrap

Unable to get manifest.json file behind Basic Auth

Open
#729 1 comment 2 reactions 0 assignees View on GitHub
enhancement
Dominant language
TypeScript
Stars
3.1k
Forks
319
PR merge metrics
No merged PRs in 30d

Description

**Describe the bug**
When running `bubblewrap init --manifest`, if the file is behind Basic Auth, the command just crashes. It doesn't ask for credentials or try to parse them from the url if they're passed on it. We are trying to generate an apk for an internal site, which is why it's not publicly available.

The error is `cli ERROR Unexpected token < in JSON at position 0`, which means it's trying to parse the 401 response HTML

**To Reproduce**
Steps to reproduce the behavior:
1. Just run the command `bubblewrap init --manifest https://jigsaw.w3.org/HTTP/Basic/` (doesn't have an actual manifest.json file behind the auth but it doesn't matter for this)

**Expected behavior**
The utility asks for the credentials, or accepts them in the format https://username:password@[host]

**Screenshots**
Not needed I think

**Desktop (please complete the following information):**
Doesn't matter

**Smartphone (please complete the following information):**
Doesn't matter

Contributor guide

Open the contributing guide

Assessment

This issue has not been assessed yet.

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.