GoogleChromeLabs / GoogleChromeLabs/bubblewrap

signingKeyPath and signingKeyAlias options of build command not override the config in twa

Open
#507 0 comments 1 reaction 0 assignees View on GitHub
Dominant language
TypeScript
Stars
3.1k
Forks
319
PR merge metrics
No merged PRs in 30d

Description

**Describe the bug**
options `--signingKeyPath` and `--signingKeyAlias` of `build` command not override the config in twa

**To Reproduce**
Steps to reproduce the behavior:
run command
`bubblewrap build --signingKeyPath ./internal-test-release.keystore --signingKeyAlias internal-test --skipPwaValidation`
or with double qoute
`bubblewrap build --signingKeyPath="./internal-test-release.keystore" --signingKeyAlias="internal-test" --skipPwaValidation`
or without double quote
`bubblewrap build --signingKeyPath=./internal-test-release.keystore --signingKeyAlias=internal-test --skipPwaValidation`

the console still prompts password for the key store and alias in twa-manifest config.

```shell
,-----. ,--. ,--. ,--.
| |) /_,--.,--| |-.| |-.| |,---.,--. ,--,--.--.,--,--.,---.
| .-. | || | .-. | .-. | | .-. | |.'.| | .--' ,-. | .-. |
| '--' ' '' | `-' | `-' | \ --| .'. | | \ '-' | '-' '
`------' `----' `---' `---'`--'`----'--' '--`--' `--`--| |-'
`--'
Please, enter passwords for the Keystore [keystore name in twa-manifest config] and alias [key alias in twa-manifest config].
```

**Expected behavior**
the console should prompt input password for the overriding Keystore path.

**Additional context**
- bubblewrap version `1.11.1`
- macOS Mojave

Contributor guide

Open the contributing guide

Assessment

This issue has not been assessed yet.

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.