GoogleChromeLabs / GoogleChromeLabs/bubblewrap
Security: CLI error prints key store password to terminal
- Dominant language
- TypeScript
- Stars
- 3.1k
- Forks
- 319
- PR merge metrics
- No merged PRs in 30d
Description
**Describe the bug**
When the CLI runs into an error, the full command used to build the apk is printed to terminal. This includes the password to the key store in plain text. I would flag this as a critical security issue, because in an automated environment anyone with access to the logs will be able to see the passwords. The passwords might also be sent to external parties if AI tooling is used in development.
**To Reproduce**
Steps to reproduce the behavior:
1. Edit the path to the keystore to be incorrect in twa-manifest.json
2. run `bubblewrap build`, answer "yes" to the update prompt
3. Give a fake password to the keystore
**Expected behavior**
Passwords used in the process are obfuscated so that their length or content is not revealed.
**Screenshots**
**Desktop (please complete the following information):**
- OS: Windows 11
- Browser: Not relevant to the issue
- Version: Not relevant to the issue
**Smartphone (please complete the following information):**
- Device: Not relevant to the issue
- OS: Not relevant to the issue
- Browser: Not relevant to the issue
- Version: Not relevant to the issue
**Additional context**
-
Contributor guide
Research direction
Start by reproducing the issue with an invalid keystore path in twa-manifest.json, then run `bubblewrap build` and inspect where the failed APK command is printed. Trace how the keystore password enters the CLI error output; done means passwords are obfuscated without revealing their content or length.
Written by the indexing model from the issue text.
Assessment
- Tech stack
- typescript
- Domain
- cli, security
- Issue type
- Bug
- Difficulty
- 3/5
- Estimated time
- 1-2 days
- Activity status
- Quiet
- Clarity
- Mostly clear
- Newbie friendliness
- 65/100