GoogleChrome / GoogleChrome/lighthouse
Lighthouse viewer error flow could be better
- Dominant language
- JavaScript
- Stars
- 30.8k
- Forks
- 9.8k
- Avg merge
- 1d 14h
- Merged PRs (30d)
- 20
Description
The following url should take ~1-2m to load an error state:
https://googlechrome.github.io/lighthouse/viewer/?psiurl=https%3A%2F%2Fwww.khaleejtimes.com%2F&strategy=mobile&category=performance&category=accessibility&category=best-practices&category=seo&utm_source=lh-chrome-ext
a) The error chip is a relatively small thing in the bottom-left corner, which goes away after a few seconds. One could easily leave the page loading, have an error response come back w/ the error warning, the warning go away, then the user finally returns their attention to the page–the page which looks very similar except without a blur.
1) We should make the error indicator stick around until dismissed
2) it should offer a "re-try" button, certainly for ?psiurl, maybe others?
b) The error message given is very generic. `Lighthouse returned error: Something went wrong.`.
1) Is that the exact error PSI is giving us? Can we do better?
2) We should link to a bug report field (perhaps only after one "retry" attempt?)
c) Why is LR having issues with https://www.khaleejtimes.com/ ? It doesn't seem like the typical site we'd have a problem with (it isn't 100% webgl)
ref https://github.com/googleads/publisher-ads-lighthouse-plugin/issues/365#issuecomment-1301873584
Contributor guide
Research direction
Start by reproducing the error in the Lighthouse viewer URL from the issue and inspect the current error-state behavior. Trace how the PSI response becomes the displayed error, including the Khaleej Times case. Done should include a persistent, dismissible error indicator, a retry path, and a more useful error or bug-report path.
Written by the indexing model from the issue text.
Assessment
- Tech stack
- javascript
- Domain
- frontend
- Issue type
- Feature
- Difficulty
- 4/5
- Estimated time
- 3-5 days
- Activity status
- Stale
- Clarity
- Needs clarification
- Newbie friendliness
- 30/100