GoogleChrome / GoogleChrome/lighthouse

Review and inject all DOM API and global dependencies

Open
#14,003 4 comments 0 reactions 1 assignee Claimed by @brendankenny View on GitHub
bug internals P2
Dominant language
JavaScript
Stars
30.8k
Forks
9.8k
Avg merge
1d 14h
Merged PRs (30d)
20

Description

Similar to #14001, #6387 and #6283, there are more dependencies on DOM APIs that might make sense to inject, like [this](https://github.com/GoogleChrome/lighthouse/blob/ff4d223bc798c76e17fd26fcbf917019f1ae5511/lighthouse-core/gather/gatherers/image-elements.js#L44) and [this](https://github.com/GoogleChrome/lighthouse/blob/ff4d223bc798c76e17fd26fcbf917019f1ae5511/lighthouse-core/gather/gatherers/image-elements.js#L73) and more. This issue to track if we want to review and convert these into injected references in some generic way vs. whack-a-mole each time a conflict occurs?

Contributor guide

Open the contributing guide

Assessment

This issue has not been assessed yet.

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.