GoogleChrome / GoogleChrome/lighthouse
Trace minifier script should keep the first screenshots after FP/FCP/LCP
Open
internals
P3
- Dominant language
- JavaScript
- Stars
- 30.8k
- Forks
- 9.8k
- Avg merge
- 1d 14h
- Merged PRs (30d)
- 20
Description
**Summary**
In https://github.com/GoogleChrome/lighthouse/pull/11874#discussion_r558590089 I was doublechecking that the FCP value was the correct one but the throttled screenshots from trace minifier script discarded the important first frame. The minifier should always keep the first screenshot after each FP/FCP/LCP event.
Contributor guide
Research direction
Locate the trace minifier script and inspect how it selects screenshots around FP, FCP, and LCP events. Verify the behavior against a trace containing those events; done means the first screenshot after each event is retained rather than discarded.
Written by the indexing model from the issue text.
Assessment
- Tech stack
- javascript
- Domain
- performance, tooling
- Issue type
- Bug
- Difficulty
- 3/5
- Estimated time
- 1-2 days
- Activity status
- Stale
- Clarity
- Mostly clear
- Newbie friendliness
- 38/100