GoogleChrome / GoogleChrome/lighthouse

Sentry logging doesn't capture error message details

Open
#11,823 1 comment 0 reactions 0 assignees View on GitHub
P3
Dominant language
JavaScript
Stars
30.8k
Forks
9.8k
Avg merge
1d 14h
Merged PRs (30d)
20

Description

https://sentry.io/organizations/google-lighthouse/issues/1927537847/events/oldest/?project=174697&query=is%3Aunresolved+release%3A6.5.0%2A&statsPeriod=14d

![image](https://user-images.githubusercontent.com/4071474/102120123-b35f6a00-3e07-11eb-8d04-edbe509ca336.png)

Even though the error does have this info:

https://github.com/GoogleChrome/lighthouse/blob/5fc0fce9e38eae97a88abfb572d8a1f18e8e7578/lighthouse-core/lib/lh-error.js#L83

https://github.com/GoogleChrome/lighthouse/blob/5fc0fce9e38eae97a88abfb572d8a1f18e8e7578/lighthouse-core/runner.js#L319

Contributor guide

Open the contributing guide

Research direction

Start with lighthouse-core/lib/lh-error.js#L83 and lighthouse-core/runner.js#L319, then compare the error data with the linked Sentry event. Trace how the error reaches Sentry and verify that its message details appear in the captured event.

Written by the indexing model from the issue text.

Assessment

Tech stack
javascript
Domain
observability
Issue type
Bug
Difficulty
3/5
Estimated time
1-2 days
Activity status
Stale
Clarity
Mostly clear
Newbie friendliness
35/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.