GoogleChrome / GoogleChrome/lighthouse

runWarnings format difficult for pragmatic usage

Open
#11,352 8 comments 0 reactions 0 assignees View on GitHub
breaking good first issue P3
Dominant language
JavaScript
Stars
30.8k
Forks
9.8k
Avg merge
1d 20h
Merged PRs (30d)
19

Description

I have two concerns with `runWarnings` specifically around pragmatic usage:

* `runWarnings` contains both errors (eg, page hung / non-successful request on main document resource) and warnings (eg, CPU throttling might be bad)
* The errors and warnings contained within `runWarnings` are strings. There's no handle to be able to identify one warning/error from another, without searching the string.

**Feature request summary**

`runWarnings` to be changed to an object. It should contain `code` and `message`. Just like `runtimeError`.

**What is the motivation or use case for changing this?**

Node.js/API/PageSpeed users of Lighthouse will be able to handle errors/warnings reliably.

Contributor guide

Open the contributing guide

Assessment

This issue has not been assessed yet.

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.